Page MenuHomePhabricator
Differential D6198

Add comments to descriptor tests
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 15:01.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC5a76fe12d233: Add comments to descriptor tests
Summary

This is a partial backport of Core PR14646 : https://github.com/bitcoin/bitcoin/pull/14646/commits/26879509f1a3b9fc0fa616164e5a88fdb344ac4d

Depends on D6197

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 21 2020, 15:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 15:01
deadalnix requested review of this revision.May 21 2020, 15:01
teamcity edited the summary of this revision. (Show Details)May 21 2020, 15:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 15:19

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 15:19

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 15:20

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 15:21

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 15:23

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 15:30

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10942: Diff 20460.May 21 2020, 15:30
majcosta accepted this revision.May 21 2020, 15:34
majcosta added a subscriber: majcosta.

test plan is a little overzealous but, looks fine

This revision is now accepted and ready to land.May 21 2020, 15:34
deadalnix added a child revision: D6200: Descriptor expansions only need pubkey entries for PKH/WPKH.May 21 2020, 15:38
Closed by commit rABC5a76fe12d233: Add comments to descriptor tests (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 21 2020, 16:08
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC5a76fe12d233: Add comments to descriptor tests.

Revision Contents
Changeset List

PathSize
src/
test/
28 lines

Diff 20468

View Options

src/test/descriptor_tests.cpp

Loading...