Page MenuHomePhabricator

[refactor] Add a base DescriptorImpl with most common logic
ClosedPublic

Authored by deadalnix on Thu, May 21, 13:54.

Details

Summary
Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Thu, May 21, 13:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 21, 13:54
deadalnix requested review of this revision.Thu, May 21, 13:54
teamcity edited the summary of this revision. (Show Details)Thu, May 21, 13:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Thu, May 21, 14:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/script/descriptor.cpp
13 ↗(On Diff #20450)

Macro wildnewlineappeared:

253 ↗(On Diff #20450)

No WPKH

256 ↗(On Diff #20450)

Nor WSH

373 ↗(On Diff #20450)

You lost the braces

548 ↗(On Diff #20450)

Restore

559 ↗(On Diff #20450)

Dito

606 ↗(On Diff #20450)

Dito

620 ↗(On Diff #20450)

Braces

622 ↗(On Diff #20450)

Restore C++ constructor

759 ↗(On Diff #20450)

Braces

768 ↗(On Diff #20450)

Dito

806 ↗(On Diff #20450)

Revert to static and auto

This revision now requires changes to proceed.Thu, May 21, 14:12
deadalnix updated this revision to Diff 20451.Thu, May 21, 14:27

Address nits and rebase

Fabien accepted this revision.Thu, May 21, 14:28
This revision is now accepted and ready to land.Thu, May 21, 14:28