Page MenuHomePhabricator
Differential D6194

[refactor] Add a base DescriptorImpl with most common logic
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 13:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2f8295ebf4e3: [refactor] Add a base DescriptorImpl with most common logic
Summary

This is a partial backport of Core PR14646 : https://github.com/bitcoin/bitcoin/pull/14646/commits/6be0fb4b3f865e80e0465c2266b0560bd6bbb406

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.May 21 2020, 13:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 13:54
deadalnix requested review of this revision.May 21 2020, 13:54
teamcity edited the summary of this revision. (Show Details)May 21 2020, 13:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 13:58

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 13:59

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 13:59

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 14:00

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 14:02

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 14:10

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10936: Diff 20450.May 21 2020, 14:10
Fabien requested changes to this revision.May 21 2020, 14:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/script/descriptor.cpp
13 ↗(On Diff #20450)

Macro wildnewlineappeared:

253 ↗(On Diff #20450)

No WPKH

256 ↗(On Diff #20450)

Nor WSH

373 ↗(On Diff #20450)

You lost the braces

548 ↗(On Diff #20450)

Restore

559 ↗(On Diff #20450)

Dito

606 ↗(On Diff #20450)

Dito

620 ↗(On Diff #20450)

Braces

622 ↗(On Diff #20450)

Restore C++ constructor

759 ↗(On Diff #20450)

Braces

768 ↗(On Diff #20450)

Dito

806 ↗(On Diff #20450)

Revert to static and auto

This revision now requires changes to proceed.May 21 2020, 14:12
deadalnix updated this revision to Diff 20451.May 21 2020, 14:27

Address nits and rebase

teamcity added a comment.May 21 2020, 14:28

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 14:28

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 14:28

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.May 21 2020, 14:28
This revision is now accepted and ready to land.May 21 2020, 14:28
teamcity added a comment.May 21 2020, 14:29

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 14:32

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

deadalnix added a child revision: D6195: [refactor] Use DescriptorImpl internally, permitting access to new methods.May 21 2020, 14:36
teamcity added a comment.May 21 2020, 14:40

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10937: Diff 20451.May 21 2020, 14:40
Closed by commit rABC2f8295ebf4e3: [refactor] Add a base DescriptorImpl with most common logic (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 21 2020, 14:51
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC2f8295ebf4e3: [refactor] Add a base DescriptorImpl with most common logic.

Revision Contents
Changeset List

PathSize
src/
script/
462 lines
2 lines

Diff 20451

View Options

src/script/descriptor.cpp

Loading...
View Options

src/script/sign.cpp

Loading...