Page MenuHomePhabricator

[refactor] Add a base DescriptorImpl with most common logic
ClosedPublic

Authored by deadalnix on May 21 2020, 13:54.

Details

Summary
Test Plan
ninja all check-all

Event Timeline

deadalnix created this revision.May 21 2020, 13:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 13:54
deadalnix requested review of this revision.May 21 2020, 13:54
teamcity edited the summary of this revision. (Show Details)May 21 2020, 13:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.May 21 2020, 14:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/script/descriptor.cpp
13

Macro wildnewlineappeared:

253

No WPKH

256

Nor WSH

373

You lost the braces

548

Restore

559

Dito

606

Dito

620

Braces

622

Restore C++ constructor

759

Braces

768

Dito

806

Revert to static and auto

This revision now requires changes to proceed.May 21 2020, 14:12
deadalnix updated this revision to Diff 20451.May 21 2020, 14:27

Address nits and rebase

Fabien accepted this revision.May 21 2020, 14:28
This revision is now accepted and ready to land.May 21 2020, 14:28