It doesn't go fetch global state implicitely now and is declared is the proper header.
Details
Details
- Reviewers
schancel - Group Reviewers
Restricted Project - Commits
- rSTAGING25fbcf451e5f: Refactor GetDifficulty from RPC
rABC25fbcf451e5f: Refactor GetDifficulty from RPC
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
chainActive.Tip() is a threadsafe singleton class?
| src/rpc/server.h | ||
|---|---|---|
| 222 ↗ | (On Diff #1591) | This is pretty strange. Can't help but wonder why they did this that way. |
Comment Actions
The singleton is not thread safe, you need to lock onto cs_main or the code is invalid.
| src/rpc/server.h | ||
|---|---|---|
| 222 ↗ | (On Diff #1591) | There is a lot of historical weirdness in that codebase. |