Page MenuHomePhabricator

Use sysctl for seeding on MacOS/BSD
ClosedPublic

Authored by Fabien on May 21 2020, 15:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCd977136bf433: Use sysctl for seeding on MacOS/BSD
Summary
Test Plan
ninja all check-all

Build for OSX (native and cross build), check the binary runs.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 21 2020, 15:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/config/bitcoin-config.h.cmake.in
61 ↗(On Diff #20466)

Isn't that guy dependent on HAVE_SYSCTL ? Something weird is going on.

This revision is now accepted and ready to land.May 21 2020, 16:01
src/config/bitcoin-config.h.cmake.in
61 ↗(On Diff #20466)

Yes , this one cannot be true if the other is not. The first detects the header while the later detects a symbol in it.

This revision was automatically updated to reflect the committed changes.