Page MenuHomePhabricator
Differential D6201

Use sysctl for seeding on MacOS/BSD
ClosedPublic
Actions

Authored by Fabien on May 21 2020, 15:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCd977136bf433: Use sysctl for seeding on MacOS/BSD
Summary

Partial backport of core PR17270:
https://github.com/bitcoin/bitcoin/pull/17270/commits/a81c494b4c9a8c2f1a319a03375826f12863706f

Test Plan
ninja all check-all

Build for OSX (native and cross build), check the binary runs.

Diff Detail

Event Timeline

Fabien created this revision.May 21 2020, 15:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 15:53
Fabien requested review of this revision.May 21 2020, 15:53
teamcity edited the summary of this revision. (Show Details)May 21 2020, 15:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 15:55

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 15:56

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 15:56

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 15:57

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 16:00

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

deadalnix accepted this revision.May 21 2020, 16:01
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/config/bitcoin-config.h.cmake.in
61

Isn't that guy dependent on HAVE_SYSCTL ? Something weird is going on.

This revision is now accepted and ready to land.May 21 2020, 16:01
teamcity added a comment.May 21 2020, 16:07

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10945: Diff 20466.May 21 2020, 16:07
Fabien added inline comments.May 21 2020, 19:16
src/config/bitcoin-config.h.cmake.in
61

Yes , this one cannot be true if the other is not. The first detects the header while the later detects a symbol in it.

Closed by commit rABCd977136bf433: Use sysctl for seeding on MacOS/BSD (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyMay 21 2020, 20:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd977136bf433: Use sysctl for seeding on MacOS/BSD.

Revision Contents
Changeset List

PathSize
14 lines
src/
config/
10 lines
6 lines
129 lines

Diff 20466

View Options

configure.ac

Loading...
View Options

src/config/CMakeLists.txt

Loading...
View Options

src/config/bitcoin-config.h.cmake.in

Loading...
View Options

src/randomenv.cpp

Loading...