Page MenuHomePhabricator

rpc: Document default values for optional arguments
ClosedPublic

Authored by deadalnix on May 22 2020, 00:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5a5256baa9ab: rpc: Document default values for optional arguments
Summary

This is a backport of Core PR14877

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.May 22 2020, 07:41
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/misc.cpp
386 ↗(On Diff #20503)

This line should be removed

src/rpc/rawtransaction.cpp
473 ↗(On Diff #20503)

Remove replaceable

1539 ↗(On Diff #20503)

Dito

src/wallet/rpcdump.cpp
1666 ↗(On Diff #20503)

Revert the doc, this sentence has been added after the PR you're backporting: D6140, https://github.com/bitcoin/bitcoin/pull/14565

1677 ↗(On Diff #20503)

Dito

This revision now requires changes to proceed.May 22 2020, 07:41
src/rpc/misc.cpp
386 ↗(On Diff #20503)

Yeah, it's redundant indeed.

This revision is now accepted and ready to land.May 22 2020, 14:48