Page MenuHomePhabricator
Differential D6140

Overhaul importmulti logic
ClosedPublic
Actions

Authored by deadalnix on May 19 2020, 15:05.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rSTAGING1e202127add7: Overhaul importmulti logic
rABC1e202127add7: Overhaul importmulti logic
Summary

This introduces various changes to the importmulti logic:

  • Instead of processing input and importing things at the same time, first process all input data and verify it, so no changes are made in case of an error.
  • Verify that no superfluous information is provided (no keys or scripts that don't contribute to solvability in particular).
  • Add way more sanity checks, by means of descending into all involved scripts.
    • Add release notes

This is a backport of Core PR14565

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 19 2020, 15:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 15:05
deadalnix requested review of this revision.May 19 2020, 15:05
teamcity edited the summary of this revision. (Show Details)May 19 2020, 15:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 19 2020, 15:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 15:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 15:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 15:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 15:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 15:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10855: Diff 20276.May 19 2020, 15:17
majcosta added a subscriber: majcosta.May 19 2020, 15:50
majcosta requested changes to this revision.May 19 2020, 16:34
majcosta added inline comments.
doc/release-notes-14565.md
5 ↗(On Diff #20276)

shouldn't this go in doc/release-notes.md?

src/wallet/rpcdump.cpp
1075 ↗(On Diff #20276)

should these comments go into their own lines as well?

This revision now requires changes to proceed.May 19 2020, 16:34
deadalnix updated this revision to Diff 20293.May 19 2020, 17:09

Update comment and remove some segwit references

majcosta requested changes to this revision.May 19 2020, 17:18
majcosta added inline comments.
doc/release-notes-14565.md
5 ↗(On Diff #20293)

delete

doc/release-notes.md
17 ↗(On Diff #20293)

I'd put that into its own section like the PR, but not that big of a deal

This revision now requires changes to proceed.May 19 2020, 17:18
deadalnix added inline comments.May 19 2020, 17:21
doc/release-notes.md
17 ↗(On Diff #20293)

This is an update to the RPC, so I think we are all good here.

teamcity added a comment.May 19 2020, 17:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 17:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 17:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 17:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10861: Diff 20293.May 19 2020, 17:34
deadalnix updated this revision to Diff 20297.May 19 2020, 18:40

release notes

teamcity added a comment.May 19 2020, 18:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 18:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 18:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 18:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 18:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 18:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10863: Diff 20297.May 19 2020, 18:56
majcosta accepted this revision.May 19 2020, 18:57
This revision is now accepted and ready to land.May 19 2020, 18:57
Closed by commit rABC1e202127add7: Overhaul importmulti logic (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 19 2020, 18:58
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC1e202127add7: Overhaul importmulti logic.
deadalnix added a commit: rSTAGING1e202127add7: Overhaul importmulti logic.
Fabien mentioned this in D6218: rpc: Document default values for optional arguments.May 22 2020, 07:41
nakihito mentioned this in D6475: Merge #15254: Trivial: fixup a few doxygen comments.Jun 9 2020, 00:21
nakihito mentioned this in rABC89c98c77854c: Merge #15254: Trivial: fixup a few doxygen comments.Jun 9 2020, 18:28

Revision Contents
Changeset List

PathSize
doc/
3 lines
src/
wallet/
431 lines
test/
functional/
107 lines

Diff 20299

View Options

doc/release-notes.md

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...