Page MenuHomePhabricator

Overhaul importmulti logic
ClosedPublic

Authored by deadalnix on Tue, May 19, 15:05.

Details

Summary

This introduces various changes to the importmulti logic:

  • Instead of processing input and importing things at the same time, first process all input data and verify it, so no changes are made in case of an error.
  • Verify that no superfluous information is provided (no keys or scripts that don't contribute to solvability in particular).
  • Add way more sanity checks, by means of descending into all involved scripts.
    • Add release notes

This is a backport of Core PR14565

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Tue, May 19, 15:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 19, 15:05
deadalnix requested review of this revision.Tue, May 19, 15:05
teamcity edited the summary of this revision. (Show Details)Tue, May 19, 15:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta requested changes to this revision.Tue, May 19, 16:34
majcosta added inline comments.
doc/release-notes-14565.md
5 ↗(On Diff #20276)

shouldn't this go in doc/release-notes.md?

src/wallet/rpcdump.cpp
1075 ↗(On Diff #20276)

should these comments go into their own lines as well?

This revision now requires changes to proceed.Tue, May 19, 16:34
deadalnix updated this revision to Diff 20293.Tue, May 19, 17:09

Update comment and remove some segwit references

majcosta requested changes to this revision.Tue, May 19, 17:18
majcosta added inline comments.
doc/release-notes-14565.md
5 ↗(On Diff #20293)

delete

doc/release-notes.md
17 ↗(On Diff #20293)

I'd put that into its own section like the PR, but not that big of a deal

This revision now requires changes to proceed.Tue, May 19, 17:18
deadalnix added inline comments.Tue, May 19, 17:21
doc/release-notes.md
17 ↗(On Diff #20293)

This is an update to the RPC, so I think we are all good here.

deadalnix updated this revision to Diff 20297.Tue, May 19, 18:40

release notes

majcosta accepted this revision.Tue, May 19, 18:57
This revision is now accepted and ready to land.Tue, May 19, 18:57
This revision was automatically updated to reflect the committed changes.