Page MenuHomePhabricator

Overhaul importmulti logic
ClosedPublic

Authored by deadalnix on May 19 2020, 15:05.

Details

Summary

This introduces various changes to the importmulti logic:

  • Instead of processing input and importing things at the same time, first process all input data and verify it, so no changes are made in case of an error.
  • Verify that no superfluous information is provided (no keys or scripts that don't contribute to solvability in particular).
  • Add way more sanity checks, by means of descending into all involved scripts.
    • Add release notes

This is a backport of Core PR14565

Test Plan
ninja all check-all

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta requested changes to this revision.May 19 2020, 16:34
majcosta added inline comments.
doc/release-notes-14565.md
5 ↗(On Diff #20276)

shouldn't this go in doc/release-notes.md?

src/wallet/rpcdump.cpp
1075 ↗(On Diff #20276)

should these comments go into their own lines as well?

This revision now requires changes to proceed.May 19 2020, 16:34

Update comment and remove some segwit references

majcosta requested changes to this revision.May 19 2020, 17:18
majcosta added inline comments.
doc/release-notes-14565.md
5

delete

doc/release-notes.md
17

I'd put that into its own section like the PR, but not that big of a deal

This revision now requires changes to proceed.May 19 2020, 17:18
doc/release-notes.md
17

This is an update to the RPC, so I think we are all good here.

This revision is now accepted and ready to land.May 19 2020, 18:57