Page MenuHomePhabricator

rpc: Actually throw help when passed invalid number of params

Authored by deadalnix on May 22 2020, 16:36.


  • rpc: Add RPCHelpMan::IsValidNumArgs()

This is a backport of Core PR15401

Depends on D6064

Test Plan
ninja all check-all

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.May 22 2020, 16:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 16:36
deadalnix requested review of this revision.May 22 2020, 16:36
teamcity edited the summary of this revision. (Show Details)May 22 2020, 16:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.May 22 2020, 17:14
This revision is now accepted and ready to land.May 22 2020, 17:14
majcosta added inline comments.May 22 2020, 17:16
435 ↗(On Diff #20517)

should we make num_args const?