Page MenuHomePhabricator

rpc: Actually throw help when passed invalid number of params
ClosedPublic

Authored by deadalnix on Fri, May 22, 16:36.

Details

Summary
  • rpc: Add RPCHelpMan::IsValidNumArgs()

This is a backport of Core PR15401

Depends on D6064

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, May 22, 16:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, May 22, 16:36
deadalnix requested review of this revision.Fri, May 22, 16:36
teamcity edited the summary of this revision. (Show Details)Fri, May 22, 16:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Fri, May 22, 17:14
This revision is now accepted and ready to land.Fri, May 22, 17:14
majcosta added inline comments.Fri, May 22, 17:16
src/rpc/util.cpp
435 ↗(On Diff #20517)

should we make num_args const?