Page MenuHomePhabricator
Differential D6220

rpc: Actually throw help when passed invalid number of params
ClosedPublic
Actions

Authored by deadalnix on May 22 2020, 16:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa299d8aa29fe: rpc: Actually throw help when passed invalid number of params
Summary
  • rpc: Add RPCHelpMan::IsValidNumArgs()

This is a backport of Core PR15401

Depends on D6064

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 22 2020, 16:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 16:36
deadalnix requested review of this revision.May 22 2020, 16:36
teamcity edited the summary of this revision. (Show Details)May 22 2020, 16:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 22 2020, 16:37

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 16:37

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 16:37

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 16:38

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 16:41

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 22 2020, 16:47

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10973: Diff 20517.May 22 2020, 16:47
majcosta added a subscriber: majcosta.May 22 2020, 17:07
Fabien accepted this revision.May 22 2020, 17:14
This revision is now accepted and ready to land.May 22 2020, 17:14
majcosta added inline comments.May 22 2020, 17:16
src/rpc/util.cpp
435 ↗(On Diff #20517)

should we make num_args const?

Closed by commit rABCa299d8aa29fe: rpc: Actually throw help when passed invalid number of params (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyMay 22 2020, 17:21
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCa299d8aa29fe: rpc: Actually throw help when passed invalid number of params.

Revision Contents
Changeset List

PathSize
src/
rpc/
180 lines
59 lines
8 lines
28 lines
test/
functional/
11 lines

Diff 20520

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

test/functional/rpc_getblockstats.py

Loading...