Page MenuHomePhabricator
Differential D6221

rpc: Document that minconf is an ignored dummy value
ClosedPublic
Actions

Authored by deadalnix on May 22 2020, 17:33.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC07a8d7d8c195: rpc: Document that minconf is an ignored dummy value
Summary

This is a partial backport of Core PR15596 : https://github.com/bitcoin/bitcoin/pull/15596/commits/fae5f874d51c770322fb18cc4050b3f14697de66

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 22 2020, 17:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 17:33
deadalnix requested review of this revision.May 22 2020, 17:34
teamcity edited the summary of this revision. (Show Details)May 22 2020, 17:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 22 2020, 17:38

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 17:39

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 17:40

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 17:40

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 17:42

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

deadalnix added a child revision: D6222: scripted-diff: wallet: Rename pcoin to wtx.May 22 2020, 17:44
teamcity added a comment.May 22 2020, 17:50

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10975: Diff 20521.May 22 2020, 17:50
majcosta accepted this revision.May 22 2020, 18:16
This revision is now accepted and ready to land.May 22 2020, 18:16
Closed by commit rABC07a8d7d8c195: rpc: Document that minconf is an ignored dummy value (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyMay 22 2020, 18:40
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC07a8d7d8c195: rpc: Document that minconf is an ignored dummy value.

Revision Contents
Changeset List

PathSize
src/
wallet/
164 lines

Diff 20531

View Options

src/wallet/rpcwallet.cpp

Loading...