Differential D6222

scripted-diff: wallet: Rename pcoin to wtx
ClosedPublic
Actions

Authored by deadalnix on May 22 2020, 17:41.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5f2c795c2512: scripted-diff: wallet: Rename pcoin to wtx

Summary

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/const CWalletTx ?\* ?pcoin = &/const CWalletTx\& wtx = /g' src/wallet/wallet.cpp
sed -i -e 's/\<pcoin->/wtx./g' src/wallet/wallet.cpp
sed -i -e 's/\<pcoin\>/\&wtx/g' src/wallet/wallet.cpp
-END VERIFY SCRIPT-

This is a partial backport of Core PR15596 : https://github.com/bitcoin/bitcoin/pull/15596/commits/faa3a246e8809b4954a4a6d202fe8c7f7f776b6e

Depends on D6221

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 22 2020, 17:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 17:41

deadalnix requested review of this revision.May 22 2020, 17:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix edited the summary of this revision. (Show Details)May 22 2020, 17:42

deadalnix edited the summary of this revision. (Show Details)

deadalnix edited the summary of this revision. (Show Details)

deadalnix added a parent revision: D6221: rpc: Document that minconf is an ignored dummy value.

deadalnix added a child revision: D6223: wallet: Remove unused GetLegacyBalance.May 22 2020, 17:45

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10978: Diff 20524.May 22 2020, 18:00

majcosta accepted this revision.May 22 2020, 18:22

This revision is now accepted and ready to land.May 22 2020, 18:22

Closed by commit rABC5f2c795c2512: scripted-diff: wallet: Rename pcoin to wtx (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyMay 22 2020, 18:42

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC5f2c795c2512: scripted-diff: wallet: Rename pcoin to wtx.

Revision Contents
Changeset List

Path

Size

src/

wallet/

102 lines

Diff 20532

src/wallet/wallet.cpp

Loading...