Page MenuHomePhabricator
Differential D6237

[build] set _FORTIFY_SOURCE=2 for -O* builds only
ClosedPublic
Actions

Authored by majcosta on May 23 2020, 00:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0e99f4cdb9bd: [build] set _FORTIFY_SOURCE=2 for -O* builds only
Summary

currently building with -DCMAKE_BUILD_TYPE=Debug floods the cli
with warnings about how _FORTIFY_SOURCE=2 requires optimization.

Our Debug build compiles with -O0 because apparently -Og drops some
symbols, so this flag should only be set for Release, RelWithDebInfo
and RelMinSize

h/t @Fabien for help with the CMake generator expressions

Test Plan
cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug
ninja

see no warnings that _FORTIFY_SOURCE requires compiling with
optimization

cmake .. -GNinja -DCMAKE_BUILD_TYPE=[the other three]
ninja -nv

see the correct flags -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 set
in the dry run output

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 23 2020, 00:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2020, 00:03
majcosta requested review of this revision.May 23 2020, 00:03
teamcity added a comment.May 23 2020, 00:08

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 23 2020, 00:10

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 23 2020, 00:11

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 23 2020, 00:11

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 23 2020, 00:14

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 23 2020, 00:22

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11001: Diff 20567.May 23 2020, 00:22
Fabien accepted this revision.May 23 2020, 15:03
This revision is now accepted and ready to land.May 23 2020, 15:03
Closed by commit rABC0e99f4cdb9bd: [build] set _FORTIFY_SOURCE=2 for -O* builds only (authored by majcosta). · Explain WhyMay 24 2020, 00:46
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC0e99f4cdb9bd: [build] set _FORTIFY_SOURCE=2 for -O* builds only.

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 20578

View Options

src/CMakeLists.txt

Loading...