Page MenuHomePhabricator
Differential D6239

refactor: Add handleNotifications method to wallet
ClosedPublic
Actions

Authored by deadalnix on May 23 2020, 19:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbef2081ba9f0: refactor: Add handleNotifications method to wallet
Summary

Further stylistic cleanups in touched files:

  • Sort the includes
  • Wrap long single-line constructors into multiple lines

This is a partial backport of Core PR15779 : https://github.com/bitcoin/bitcoin/pull/15779/commits/fad7c33342cb51b310a7dd372bfa675df8810367

Depends on D6236

Test Plan
ninja all check-all
./src/bench/bitcoin-bench

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 23 2020, 19:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2020, 19:11
deadalnix requested review of this revision.May 23 2020, 19:11
teamcity edited the summary of this revision. (Show Details)May 23 2020, 19:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 23 2020, 19:11

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 23 2020, 19:11

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 23 2020, 19:11

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 23 2020, 19:13

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Fabien accepted this revision.May 23 2020, 19:15
This revision is now accepted and ready to land.May 23 2020, 19:15
teamcity added a comment.May 23 2020, 19:17

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 23 2020, 19:21

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11005: Diff 20574.May 23 2020, 19:21
Closed by commit rABCbef2081ba9f0: refactor: Add handleNotifications method to wallet (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyMay 23 2020, 19:48
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCbef2081ba9f0: refactor: Add handleNotifications method to wallet.

Revision Contents
Changeset List

PathSize
src/
bench/
26 lines
wallet/
test/
3 lines
5 lines
7 lines

Diff 20577

View Options

src/bench/wallet_balance.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...