Page MenuHomePhabricator
Differential D6236

bench: Add wallet_balance benchmarks
ClosedPublic
Actions

Authored by deadalnix on May 22 2020, 23:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbf444f46b27e: bench: Add wallet_balance benchmarks
Summary

This is a partial backport of Core PR15779 : https://github.com/bitcoin/bitcoin/pull/15779/commits/fa46ac3127142358116c8473741708b3bb70ca15

Also include pieces of PR15788 that previously were ignored becauseit was dead code.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 22 2020, 23:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 23:32
deadalnix requested review of this revision.May 22 2020, 23:32
teamcity edited the summary of this revision. (Show Details)May 22 2020, 23:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 22 2020, 23:45

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 23:46

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 23:48

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 23:48

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 23:50

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 23 2020, 00:00

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10998: Diff 20562.May 23 2020, 00:00
deadalnix updated this revision to Diff 20569.May 23 2020, 00:19

rebase

teamcity added a comment.May 23 2020, 00:27

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 23 2020, 00:29

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 23 2020, 00:29

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 23 2020, 00:30

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 23 2020, 00:34

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 23 2020, 00:42

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11002: Diff 20569.May 23 2020, 00:42
deadalnix edited the summary of this revision. (Show Details)May 23 2020, 18:38
deadalnix updated this revision to Diff 20573.May 23 2020, 18:44

rebase

teamcity added a comment.May 23 2020, 18:44

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 23 2020, 18:45

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 23 2020, 18:45

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 23 2020, 18:47

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 23 2020, 18:48

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 23 2020, 18:56

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11004: Diff 20573.May 23 2020, 18:56
Fabien accepted this revision.May 23 2020, 18:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/util.cpp
14 ↗(On Diff #20573)

Surround with #ifdef ENABLE_WALLET

28 ↗(On Diff #20573)

Might as well skip this, I'll leave that up to you

This revision is now accepted and ready to land.May 23 2020, 18:59
deadalnix added a child revision: D6239: refactor: Add handleNotifications method to wallet.May 23 2020, 19:11
deadalnix updated this revision to Diff 20575.May 23 2020, 19:38

Add guards around incusion of wallet.h

teamcity added a comment.May 23 2020, 19:38

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 23 2020, 19:38

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 23 2020, 19:38

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 23 2020, 19:41

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 23 2020, 19:41

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

This revision was landed with ongoing or failed builds.May 23 2020, 19:48
Closed by commit rABCbf444f46b27e: bench: Add wallet_balance benchmarks (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCbf444f46b27e: bench: Add wallet_balance benchmarks.
teamcity added a comment.May 23 2020, 19:48

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11006: Diff 20575.May 23 2020, 19:48

Revision Contents
Changeset List

PathSize
src/
1 line
bench/
6 lines
95 lines
test/
14 lines
47 lines

Diff 20576

View Options

src/Makefile.bench.include

Loading...
View Options

src/bench/CMakeLists.txt

Loading...
View Options

src/bench/wallet_balance.cpp

Loading...
View Options

src/test/util.h

Loading...
View Options

src/test/util.cpp

Loading...