Page MenuHomePhabricator

The color display is added to the test results of pyzmq ,Green is passed, Red is not passed
AbandonedPublic

Authored by deadalnix on Oct 27 2017, 07:22.

Details

Reviewers
schancel
jjz
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Summary

use colors to distinguish test results

Test Plan

qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1026
Build 1026: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 27 2017, 07:22
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptOct 27 2017, 07:22

use autopep8 to format python code

Hi jjz,

Thanks for the patch! Is this just autopep8 changes? I don't see anything related to adding colors to the test results.

Hi jjz,

Thanks for the patch! Is this just autopep8 changes? I don't see anything related to adding colors to the test results.

There are two commit ,the last is a autopep8 changes, the first commit (https://reviews.bitcoinabc.org/D625?id=1607) is adding colors to the test results . Next time I try to use commit as mush as possible.

Hi jjz,

I don't see the other commit in the Phabricator UI. I believe every diff in phabricator is intended to be a single commit. Are you using arcanist to generate patches? If so you need to amend your commit before running arc diff

Hi jjz,

I don't see the other commit in the Phabricator UI. I believe every diff in phabricator is intended to be a single commit. Are you using arcanist to generate patches? If so you need to amend your commit before running arc diff

the first commit I use arc diff, second commit I use arc diff -update D625, Do I need to resend a new DIFF?

Hi jjz,

I don't see the other commit in the Phabricator UI. I believe every diff in phabricator is intended to be a single commit. Are you using arcanist to generate patches? If so you need to amend your commit before running arc diff

I resubmitted a new a diff https://reviews.bitcoinabc.org/D627 , Thank you for your time

This should be abandoned in favor of D627

deadalnix abandoned this revision.
deadalnix edited reviewers, added: jjz; removed: deadalnix.