use colors to distinguish test results
Details
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- master
- Lint
Lint Passed Severity Location Code Message Auto-Fix qa/pull-tester/rpc-tests.py:1 CFMT Code style violation - Unit
No Test Coverage - Build Status
Buildable 1025 Build 1025: arc lint + arc unit
Event Timeline
Hi jjz,
Thanks for the patch! Is this just autopep8 changes? I don't see anything related to adding colors to the test results.
There are two commit ,the last is a autopep8 changes, the first commit (https://reviews.bitcoinabc.org/D625?id=1607) is adding colors to the test results . Next time I try to use commit as mush as possible.
Hi jjz,
I don't see the other commit in the Phabricator UI. I believe every diff in phabricator is intended to be a single commit. Are you using arcanist to generate patches? If so you need to amend your commit before running arc diff
the first commit I use arc diff, second commit I use arc diff -update D625, Do I need to resend a new DIFF?
I resubmitted a new a diff https://reviews.bitcoinabc.org/D627 , Thank you for your time