Differential D6251

[CMAKE] Move the OpenSSL symbol detection to Qt rather than config
ClosedPublic
Actions

Authored by Fabien on May 25 2020, 19:18.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCf5a55e228fe3: [CMAKE] Move the OpenSSL symbol detection to Qt rather than config

Summary

This is a follow-up for the comment
https://reviews.bitcoinabc.org/D6243#inline-39530

The symbol is tightly coupled to OpenSSL, which only use it for BIP70
support in the GUI. This diff moves the check in the GUI where it
belongs and sets a preprocessor definition instead of setting the
definition in the config header.

Test Plan

ninja all check-bitcoin-qt

Cross build for all platforms.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 25 2020, 19:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2020, 19:18

Fabien requested review of this revision.May 25 2020, 19:18

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Fix component

Fabien added a child revision: D6243: [BUILD] Search and include OpenSSL only where required.May 25 2020, 19:22

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11018: Diff 20598.May 25 2020, 19:29

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11019: Diff 20599.May 25 2020, 19:33

You need to fix the cmake file, but this looks good.

src/qt/CMakeLists.txt
260 ↗	(On Diff #20599)	There is something screwed up with the indentation. It seems like linter that warn about this wouldn't be very difficult to write, but maybe not.