See title.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABC9fc0ab8ec1ea: Add land bot dependencies to base image setup script
./build-containers/build.sh -r reg-staging.bitframe.org -c ~/projects/bitcoin-abc -f ./contrib -s ./teamcity/setup-debian-buster.sh -t abc-land-bot debian:buster ""
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Why would we want the land bot to use different dependencies that CI builds?
| contrib/teamcity/setup-land-bot.sh | ||
|---|---|---|
| 27 ↗ | (On Diff #20631) | apt also ship these. Not sure why pip is needed here. |
Comment Actions
The main driver was I didn't want to bloat the CI base image with dependencies that aren't used by the builds at all. We use more tools while developing than we do while building, so it seemed logical to separate these.
I imagined expanding this base image with more dependencies as autogen tooling takes hold in the land bot, which would cause more bloat in the original base image.
The only downside I saw was potential dependency conflicts that only exist for the land bot and not elsewhere, but this is minimal and manageable.
But now I see there is another downside that I didn't fully consider: Making this base image separate actually unnecessarily complicates the task of writing tests for the land bot, which may discourage doing so all together. Clearly this is not worth it.
If we do encounter issues due to base image bloat, we'll need to find another solution.
| contrib/teamcity/setup-land-bot.sh | ||
|---|---|---|
| 27 ↗ | (On Diff #20631) | Good catch. I didn't realize those exist separately from pip. |