Page MenuHomePhabricator

[wallet] Move maxTxFee to wallet
ClosedPublic

Authored by deadalnix on May 27 2020, 13:32.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC8a33d815de4c: [wallet] Move maxTxFee to wallet
Summary

This commit moves the maxtxfee setting to the wallet. There is only
one minor behavior change:

  • an error message in feebumper now refers to -maxtxfee instead of

maxTxFee.

Backport of Core PR15778

Depends on D6266

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Snippet of first build failure:

[13:34:17] :	 [Step 1/2] [14/16] Linking CXX executable src/qt/test/test_bitcoin-qt
[13:34:17] :	 [Step 1/2] [15/16] bitcoin-qt: testing test_bitcoin-qt
[13:34:17] :	 [Step 1/2] [16/16] Running bitcoin-qt test suite
[13:34:17] :	 [Step 1/2] PASSED: bitcoin-qt test suite
[13:34:17]W:	 [Step 1/2] + ninja check-functional
[13:34:17] :	 [Step 1/2] [0/1] Run the functional tests
[13:34:17]W:	 [Step 1/2] Starting Bitcoin ABC functional tests
[13:34:17]W:	 [Step 1/2] Temporary test directory at /work/build/test/tmp/test_runner_₿₵_  _20200527_133417
[13:34:18]W:	 [Step 1/2] Traceback (most recent call last):
[13:34:18]W:	 [Step 1/2]   File "/work/test/functional/create_cache.py", line 30, in <module>
[13:34:18]W:	 [Step 1/2]     CreateCache().main()
[13:34:18]W:	 [Step 1/2]   File "/work/test/functional/test_framework/test_framework.py", line 188, in main
[13:34:18]W:	 [Step 1/2]     self.stop_nodes()
[13:34:18]W:	 [Step 1/2]   File "/work/test/functional/test_framework/test_framework.py", line 372, in stop_nodes
[13:34:18]W:	 [Step 1/2]     node.stop_node(wait=wait)
[13:34:18]W:	 [Step 1/2]   File "/work/test/functional/test_framework/test_node.py", line 316, in stop_node
[13:34:18]W:	 [Step 1/2]     self.stop(wait=wait)
[13:34:18]W:	 [Step 1/2]   File "/work/test/functional/test_framework/test_node.py", line 192, in __getattr__
[13:34:18]W:	 [Step 1/2]     "Error: RPC not initialized")
[13:34:18]W:	 [Step 1/2] AssertionError: [node 0] Error: RPC not initialized
[13:34:18] :	 [Step 1/2] 2020-05-27T13:34:17.853000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200527_133417/cache
[13:34:18] :	 [Step 1/2] 2020-05-27T13:34:18.105000Z TestFramework (ERROR): Unexpected exception caught during testing
[13:34:18] :	 [Step 1/2] Traceback (most recent call last):
[13:34:18] :	 [Step 1/2]   File "/work/test/functional/test_framework/test_framework.py", line 161, in main
[13:34:18] :	 [Step 1/2]     self.setup_chain()
[13:34:18] :	 [Step 1/2]   File "/work/test/functional/test_framework/test_framework.py", line 239, in setup_chain
[13:34:18] :	 [Step 1/2]     self._initialize_chain()
[13:34:18] :	 [Step 1/2]   File "/work/test/functional/test_framework/test_framework.py", line 489, in _initialize_chain
[13:34:18] :	 [Step 1/2]     self.start_node(CACHE_NODE_ID)
[13:34:18] :	 [Step 1/2]   File "/work/test/functional/test_framework/test_framework.py", line 337, in start_node
[13:34:18] :	 [Step 1/2]     node.wait_for_rpc_connection()
[13:34:18] :	 [Step 1/2]   File "/work/test/functional/test_framework/test_node.py", line 258, in wait_for_rpc_connection
[13:34:18] :	 [Step 1/2]     'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
[13:34:18] :	 [Step 1/2] test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status -6 during initialization
[13:34:18] :	 [Step 1/2] 2020-05-27T13:34:18.158000Z TestFramework (INFO): Stopping nodes
[13:34:18] :	 [Step 1/2] [node 0] Cleaning up leftover process
[13:34:18]W:	 [Step 1/2] Traceback (most recent call last):
[13:34:18]W:	 [Step 1/2]   File "./functional/test_runner.py", line 872, in <module>
[13:34:18]W:	 [Step 1/2]     main()
[13:34:18]W:	 [Step 1/2]   File "./functional/test_runner.py", line 354, in main
[13:34:18]W:	 [Step 1/2]     failfast=args.failfast
[13:34:18]W:	 [Step 1/2]   File "./functional/test_runner.py", line 391, in run_tests
[13:34:18]W:	 [Step 1/2]     tests_dir, 'create_cache.py')] + flags + [os.path.join("--tmpdir={}", "cache") .format(tmpdir)])
[13:34:18]W:	 [Step 1/2]   File "/usr/lib/python3.7/subprocess.py", line 395, in check_output
[13:34:18]W:	 [Step 1/2]     **kwargs).stdout
[13:34:18]W:	 [Step 1/2]   File "/usr/lib/python3.7/subprocess.py", line 487, in run
[13:34:18]W:	 [Step 1/2]     output=stdout, stderr=stderr)
[13:34:18]W:	 [Step 1/2] subprocess.CalledProcessError: Command '['/usr/bin/python3.7', '/work/test/functional/create_cache.py', '--cachedir=/work/build/test/cache', '--configfile=/work/build/test/functional/../config.ini', '--tmpdir=/work/build/test/tmp/test_runner_₿₵_  _20200527_133417/cache']' returned non-zero exit status 1.
[13:34:18] :	 [Step 1/2] FAILED: test/CMakeFiles/check-functional 
[13:34:18] :	 [Step 1/2] cd /work/build/test && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py
[13:34:18] :	 [Step 1/2] ninja: build stopped: subcommand failed.
[13:34:18]W:	 [Step 1/2] ++ print_sanitizers_log
[13:34:18]W:	 [Step 1/2] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[13:34:18]W:	 [Step 1/2] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[13:34:18]W:	 [Step 1/2] ++ cat '/tmp/sanitizer_logs/*.log.*'
[13:34:18] :	 [Step 1/2] *** Output of /tmp/sanitizer_logs/*.log.* ***
[13:34:18]W:	 [Step 1/2] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[13:34:19]W:	 [Step 1/2] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[13:34:24]W:	 [Step 1/2] Process exited with code 1
[13:34:24]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/wallet.cpp
4709 ↗(On Diff #20634)

It looks like Core is actually missing the .translated on these strings..

This revision is now accepted and ready to land.May 27 2020, 16:14
This revision was automatically updated to reflect the committed changes.