Page MenuHomePhabricator

Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds
ClosedPublic

Authored by freetrader on Oct 29 2017, 02:35.

Details

Summary

Use of deleted function declaration broke older C++11 compilers.
(https://github.com/Bitcoin-ABC/bitcoin-abc/issues/98)
This enables GCC 7.2.0 from Ubuntu's toolchain repository.

Travis unfortunately offers limited support for newer versions
of the toolchains we need - but with this changeset we can at least
get Linux x86_64, i686 and Apple cross-compilation builds working again.

ARM and Windows builds are non-functional and have been removed for now.
To get them to work we would need improved versions of at least:

  • g++-arm-linux-gnueabihf
  • g++-mingw-w64-i686
  • g++-mingw-w64-x86-64

It is better to have Travis working for a subset of platforms than
to have it constantly fail the entire suite, even if short/medium term
it seems we need to move away from Travis due to its lack of currency.

Test Plan

check Travis build results

Diff Detail

Repository
rABC Bitcoin ABC
Branch
travis_restore_some_builds
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1030
Build 1030: arc lint + arc unit

Event Timeline

freetrader created this revision.Oct 29 2017, 02:35
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptOct 29 2017, 02:35

Test result on Travis with these changes in a private branch:

https://travis-ci.org/ftrader-bitcoinabc/bitcoin-abc/builds/294141142

freetrader added a comment.EditedOct 31 2017, 03:44

For consideration of 0.16.0 release: It is better to have Travis working for a subset of platforms than to have it constantly fail the entire suite

D626 on top of 0.16.0 - still green for 0.16.0

https://travis-ci.org/ftrader-bitcoinabc/bitcoin-abc/builds/295094932

schancel accepted this revision.Oct 31 2017, 15:22
This revision is now accepted and ready to land.Oct 31 2017, 15:22
This revision was automatically updated to reflect the committed changes.