[backport#15139] util: Make ToLower and ToUpper take a char
ClosedPublic
Actions

Authored by majcosta on May 29 2020, 18:04.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC47de8cc58f9c: [backport#15139] util: Make ToLower and ToUpper take a char

Summary

Unfortunately, std::string elements are (bare) chars. As these
are the most likely type to be passed to these functions, make them use
char instead of unsigned char. This avoids some casts.

https://github.com/bitcoin/bitcoin/pull/15139/commits/332b3dd7c156daa08df347dc3359f0ee99ce4baa

Depends on D6294

Concludes backport of Core PR15139

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 29 2020, 18:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2020, 18:04

majcosta requested review of this revision.May 29 2020, 18:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11087: Diff 20708.May 29 2020, 18:18

deadalnix requested changes to this revision.May 29 2020, 21:32

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/util/strencodings.h
224 ↗	(On Diff #20708)	Please use char here as the intent is for this to be a character, not a signed 8bit integer. Also, char signedness is plateform dependent.