Page MenuHomePhabricator
Differential D6297

[backport#15932] rpc: Serialize in getblock without cs_main
ClosedPublic
Actions

Authored by majcosta on May 29 2020, 18:49.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rABC6cd4a39874a9: [backport#15932] rpc: Serialize in getblock without cs_main
Summary

https://github.com/bitcoin/bitcoin/pull/15932/commits/fab00a5cb90053e9671627af6a35e57610a44e89

Depends on D6296

Partial backport of Core PR15932

Test Plan
cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 29 2020, 18:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2020, 18:49
majcosta requested review of this revision.May 29 2020, 18:49
teamcity edited the summary of this revision. (Show Details)May 29 2020, 18:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 29 2020, 18:49

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 29 2020, 18:49

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 29 2020, 18:49

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 29 2020, 18:50

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 29 2020, 18:54

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 29 2020, 18:58

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11090: Diff 20711.May 29 2020, 18:59
majcosta added a child revision: D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.May 29 2020, 19:57
nakihito accepted this revision.May 29 2020, 19:59
This revision is now accepted and ready to land.May 29 2020, 19:59
nakihito requested changes to this revision.May 29 2020, 20:03

Test plan doesn't test lock changes.

This revision now requires changes to proceed.May 29 2020, 20:03
majcosta edited the test plan for this revision. (Show Details)May 29 2020, 20:14
majcosta edited the test plan for this revision. (Show Details)May 30 2020, 01:32
majcosta requested review of this revision.May 30 2020, 01:46

fixed test plan

nakihito accepted this revision.May 30 2020, 05:26
This revision is now accepted and ready to land.May 30 2020, 05:26
Closed by commit rABC6cd4a39874a9: [backport#15932] rpc: Serialize in getblock without cs_main (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 1 2020, 12:55
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC6cd4a39874a9: [backport#15932] rpc: Serialize in getblock without cs_main.

Revision Contents
Changeset List

PathSize
src/
rpc/
27 lines

Diff 20745

View Options

src/rpc/blockchain.cpp

Loading...