Page MenuHomePhabricator
Differential D6296

[backport#15932] rpc: Use IsValidNumArgs in getblock
ClosedPublic
Actions

Authored by majcosta on May 29 2020, 18:34.

Details

Reviewers
nakihito
deadalnix
Group Reviewers
Restricted Project
Commits
rABCbb7cea810c56: [backport#15932] rpc: Use IsValidNumArgs in getblock
Summary

https://github.com/bitcoin/bitcoin/pull/15932/commits/fa1c3591add184ecb43eb3b149f4833f241e3858

Partial backport of Core PR15932

Test Plan
ninja check check-functional

run bitcoin-cli getblock and check that layout is nice and lined up

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 29 2020, 18:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2020, 18:34
majcosta requested review of this revision.May 29 2020, 18:34
teamcity edited the summary of this revision. (Show Details)May 29 2020, 18:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 29 2020, 18:35

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 29 2020, 18:35

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 29 2020, 18:35

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 29 2020, 18:36

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 29 2020, 18:38

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 29 2020, 18:44

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11088: Diff 20709.May 29 2020, 18:44
majcosta added a child revision: D6297: [backport#15932] rpc: Serialize in getblock without cs_main.May 29 2020, 18:49
nakihito accepted this revision.May 29 2020, 19:57
This revision is now accepted and ready to land.May 29 2020, 19:57
nakihito requested changes to this revision.May 29 2020, 20:04

Test plan is insufficient.

This revision now requires changes to proceed.May 29 2020, 20:04
majcosta requested review of this revision.May 29 2020, 20:13
majcosta edited the test plan for this revision. (Show Details)

expanded test plan

deadalnix requested changes to this revision.May 29 2020, 21:17
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/rpc/blockchain.cpp
989 ↗(On Diff #20709)

Try to relayout this. You can make line longer and let clang-format split them again. I suspect several of them that have been split may now fit on one line.

This revision now requires changes to proceed.May 29 2020, 21:17
majcosta edited the test plan for this revision. (Show Details)May 30 2020, 00:31
majcosta updated this revision to Diff 20730.May 30 2020, 00:45

updated test plan and reformatted and relayouted the cli command's help output

teamcity added a comment.May 30 2020, 00:48

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 30 2020, 00:49

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 30 2020, 00:50

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 30 2020, 00:51

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 30 2020, 00:52

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

nakihito accepted this revision.May 30 2020, 00:57
teamcity added a comment.May 30 2020, 01:01

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11102: Diff 20730.May 30 2020, 01:01
deadalnix accepted this revision.May 31 2020, 22:02
This revision is now accepted and ready to land.May 31 2020, 22:02
Closed by commit rABCbb7cea810c56: [backport#15932] rpc: Use IsValidNumArgs in getblock (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 1 2020, 12:54
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCbb7cea810c56: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Revision Contents
Changeset List

PathSize
src/
rpc/
152 lines

Diff 20744

View Options

src/rpc/blockchain.cpp

Loading...