Page MenuHomePhabricator

[backport#15932] rpc: Use IsValidNumArgs in getblock
ClosedPublic

Authored by majcosta on May 29 2020, 18:34.

Details

Summary
Test Plan
ninja check check-functional

run bitcoin-cli getblock and check that layout is nice and lined up

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 29 2020, 19:57
nakihito requested changes to this revision.May 29 2020, 20:04

Test plan is insufficient.

This revision now requires changes to proceed.May 29 2020, 20:04
majcosta edited the test plan for this revision. (Show Details)

expanded test plan

deadalnix requested changes to this revision.May 29 2020, 21:17
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/rpc/blockchain.cpp
989 ↗(On Diff #20709)

Try to relayout this. You can make line longer and let clang-format split them again. I suspect several of them that have been split may now fit on one line.

This revision now requires changes to proceed.May 29 2020, 21:17

updated test plan and reformatted and relayouted the cli command's help output

This revision is now accepted and ready to land.May 31 2020, 22:02