Page MenuHomePhabricator

Merge #14426: utils: Fix broken Windows filelock
ClosedPublic

Authored by jasonbcox on Jun 2 2020, 22:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC2800cca7367a: Merge #14426: utils: Fix broken Windows filelock
Summary

369244f654 utils: Fix broken Windows filelock (Chun Kuan Lee)

Pull request description:

Fix broken filelock on Windows, also add a test for this. It's a regression introduced by #13862.

Tree-SHA512: 15665b1930cf39ec71f3ab07def8e2897659f6fd4d2de749d63a5a8ec920e4a04282f12bc262f242b1b3d14d2dd9fa191ddbcf16a46fb927b5b2b14d9f6b5d01

Backport Core of PR14426

Test Plan

ninja check check-functional

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jun 2 2020, 23:07