Page MenuHomePhabricator
Differential D6334

Merge #14426: utils: Fix broken Windows filelock
ClosedPublic
Actions

Authored by jasonbcox on Jun 2 2020, 22:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC2800cca7367a: Merge #14426: utils: Fix broken Windows filelock
Summary

369244f654 utils: Fix broken Windows filelock (Chun Kuan Lee)

Pull request description:

Fix broken filelock on Windows, also add a test for this. It's a regression introduced by #13862.

Tree-SHA512: 15665b1930cf39ec71f3ab07def8e2897659f6fd4d2de749d63a5a8ec920e4a04282f12bc262f242b1b3d14d2dd9fa191ddbcf16a46fb927b5b2b14d9f6b5d01

Backport Core of PR14426

Test Plan

ninja check check-functional

Diff Detail

Event Timeline

jasonbcox created this revision.Jun 2 2020, 22:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2020, 22:04
jasonbcox requested review of this revision.Jun 2 2020, 22:04
teamcity edited the summary of this revision. (Show Details)Jun 2 2020, 22:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11150: Diff 20813.Jun 2 2020, 22:16
deadalnix accepted this revision.Jun 2 2020, 23:07
This revision is now accepted and ready to land.Jun 2 2020, 23:07
Closed by commit rABC2800cca7367a: Merge #14426: utils: Fix broken Windows filelock (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by jasonbcox). · Explain WhyJun 3 2020, 00:29
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC2800cca7367a: Merge #14426: utils: Fix broken Windows filelock.

Revision Contents
Changeset List

PathSize
src/
4 lines
test/
functional/
47 lines

Diff 20813

View Options

src/fs.cpp

Loading...
View Options

test/functional/feature_filelock.py

Loading...