Page MenuHomePhabricator
Differential D634

Convert policy fees.cpp/.h to use Amount class
ClosedPublic
Actions

Authored by schancel on Nov 3 2017, 20:26.

Details

Reviewers
deadalnix
freetrader
Group Reviewers
Restricted Project
Commits
rSTAGINGe3ac072133aa: Convert policy fees.cpp/.h to use Amount class
rABCe3ac072133aa: Convert policy fees.cpp/.h to use Amount class
Summary

Convert fees.cpp and fees.h to use Amount class. Update
dependencies where appropriate. FeeStats could not be swapped
from using double due to a file format dependency.

Test Plan

make VERBOSE=1 check && ./qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
shammah/amount-final
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1047
Build 1047: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 3 2017, 20:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2017, 20:26
schancel updated this revision to Diff 1638.Nov 3 2017, 22:59

Convert rpc package to use Amount class

Harbormaster completed remote builds in B1048: Diff 1638.Nov 3 2017, 23:00
freetrader accepted this revision.Nov 4 2017, 13:56

Looks good and tests fine.

This revision is now accepted and ready to land.Nov 4 2017, 13:56
schancel updated this revision to Diff 1648.Nov 5 2017, 18:08

Rebase and remove mistakenly added code from rpc package

Closed by commit rABCe3ac072133aa: Convert policy fees.cpp/.h to use Amount class (authored by schancel, committed by schancel). · Explain WhyNov 5 2017, 18:21
This revision was automatically updated to reflect the committed changes.
deadalnix added inline comments.Nov 6 2017, 13:16
src/policy/fees.cpp
349 ↗(On Diff #1649)

The semantic of that code has changed.

566 ↗(On Diff #1649)

dito

Revision Contents
Changeset List

PathSize
src/
bench/
2 lines
policy/
12 lines
21 lines
test/
11 lines
4 lines

Diff 1637

View Options

src/bench/coin_selection.cpp

Loading...
View Options

src/policy/fees.h

Loading...
View Options

src/policy/fees.cpp

Loading...
View Options

src/test/policyestimator_tests.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...