Page MenuHomePhabricator

Remove memcpy compatibility for glibc < 2.14
ClosedPublic

Authored by Fabien on Jun 3 2020, 21:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC9ca230dfe09a: Remove memcpy compatibility for glibc < 2.14
Summary

This makes memcpy having undefined behavior when memory overlaps,
while memmove (previously aliased) used to be safer in this regard.
Hopefully UBSAN will catch this kind of issues.

Depends on D6342.

Test Plan
ninja all check-all
make check

Run the Gitian builds.

Run the tests with UBSAN.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable