Page MenuHomePhabricator
Differential D6364

Context isn't freed in the ECDH benchmark
ClosedPublic
Actions

Authored by deadalnix on Jun 4 2020, 10:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC270f3194d8a2: Context isn't freed in the ECDH benchmark
Summary
  • free the ctx at the end of bench_ecdh
  • Pass num of iters to benchmarks as variable, and define envvar
  • Add running benchmarks regularly and under valgrind in travis

This is a backport of libsecp256k1 PR722

Test Plan
ninja all check check-secp256k1 bench-secp256k1

Diff Detail

Event Timeline

deadalnix created this revision.Jun 4 2020, 10:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2020, 10:26
deadalnix requested review of this revision.Jun 4 2020, 10:26
teamcity edited the summary of this revision. (Show Details)Jun 4 2020, 10:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11192: Diff 20879.Jun 4 2020, 10:35
Fabien requested changes to this revision.Jun 4 2020, 13:20
Fabien added a subscriber: Fabien.

Consider adding bench_multiset as well for completeness.

src/secp256k1/.travis.yml
59 ↗(On Diff #20879)

BENCH=

src/secp256k1/travis/build_autotools.sh
63 ↗(On Diff #20879)

Add bench_multiset ?

This revision now requires changes to proceed.Jun 4 2020, 13:20
deadalnix added inline comments.Jun 4 2020, 14:07
src/secp256k1/travis/build_autotools.sh
63 ↗(On Diff #20879)

We'd have to update it to make the iter count variable first.

deadalnix updated this revision to Diff 20889.Jun 4 2020, 14:12

Update travis.

Harbormaster completed remote builds in B11198: Diff 20889.Jun 4 2020, 14:20
Fabien accepted this revision.Jun 4 2020, 15:02
This revision is now accepted and ready to land.Jun 4 2020, 15:02
deadalnix added a child revision: D6372: Update multiset hash benchmark to use get_iters.Jun 4 2020, 16:08
Closed by commit rABC270f3194d8a2: Context isn't freed in the ECDH benchmark (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by deadalnix). · Explain WhyJun 4 2020, 16:17
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC270f3194d8a2: Context isn't freed in the ECDH benchmark.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
6 lines
src/
15 lines
15 lines
41 lines
178 lines
8 lines
14 lines
21 lines
travis/
17 lines

Diff 20889

View Options

src/secp256k1/.travis.yml

Loading...
View Options

src/secp256k1/src/bench.h

Loading...
View Options

src/secp256k1/src/bench_ecdh.c

Loading...
View Options

src/secp256k1/src/bench_ecmult.c

Loading...
View Options

src/secp256k1/src/bench_internal.c

Loading...
View Options

src/secp256k1/src/bench_recover.c

Loading...
View Options

src/secp256k1/src/bench_sign.c

Loading...
View Options

src/secp256k1/src/bench_verify.c

Loading...
View Options

src/secp256k1/travis/build_autotools.sh

Loading...