Page MenuHomePhabricator

Context isn't freed in the ECDH benchmark
ClosedPublic

Authored by deadalnix on Jun 4 2020, 10:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC270f3194d8a2: Context isn't freed in the ECDH benchmark
Summary
  • free the ctx at the end of bench_ecdh
  • Pass num of iters to benchmarks as variable, and define envvar
  • Add running benchmarks regularly and under valgrind in travis

This is a backport of libsecp256k1 PR722

Test Plan
ninja all check check-secp256k1 bench-secp256k1

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Jun 4 2020, 13:20
Fabien added a subscriber: Fabien.

Consider adding bench_multiset as well for completeness.

src/secp256k1/.travis.yml
59 ↗(On Diff #20879)

BENCH=

src/secp256k1/travis/build_autotools.sh
63 ↗(On Diff #20879)

Add bench_multiset ?

This revision now requires changes to proceed.Jun 4 2020, 13:20
src/secp256k1/travis/build_autotools.sh
63 ↗(On Diff #20879)

We'd have to update it to make the iter count variable first.

This revision is now accepted and ready to land.Jun 4 2020, 15:02