Page MenuHomePhabricator
Differential D6377

util: Add Join helper to join a list of strings
ClosedPublic
Actions

Authored by deadalnix on Jun 4 2020, 21:44.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC4c00f172dd60: util: Add Join helper to join a list of strings
Summary
  • util: Add Join helper to join a list of strings
  • rpc: Use Join helper in rpc/util

This is a backport of Core PR16670

Depends on D6376

Test Plan

ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.Jun 4 2020, 21:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2020, 21:44
deadalnix requested review of this revision.Jun 4 2020, 21:44
teamcity edited the summary of this revision. (Show Details)Jun 4 2020, 21:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11216: Diff 20924.Jun 4 2020, 22:02
jasonbcox accepted this revision.Jun 4 2020, 23:05
This revision is now accepted and ready to land.Jun 4 2020, 23:05
Closed by commit rABC4c00f172dd60: util: Add Join helper to join a list of strings (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJun 4 2020, 23:10
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC4c00f172dd60: util: Add Join helper to join a list of strings.

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
rpc/
11 lines
test/
15 lines
util/
37 lines
5 lines

Diff 20924

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/string.h

Loading...
View Options

src/util/string.cpp

Loading...