Differential D6378

[devtools] Use a trap to cleanup bitcoind instead of a background process
ClosedPublic
Actions

Authored by jasonbcox on Jun 4 2020, 22:28.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC3aa12ec3b525: [devtools] Use a trap to cleanup bitcoind instead of a background process

Summary

This improves code locality, making it easier to reason about.
This also removes an unnecessary looping sleep.

Test Plan

./bitcoind-exit-on-log.sh --grep 'New outbound peer connected' --params "-datadir=/home/jasonbcox/.bitcoin"
ps aux | grep bitcoind

Verify no dangling processes

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 4 2020, 22:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2020, 22:28

jasonbcox requested review of this revision.Jun 4 2020, 22:28

deadalnix accepted this revision.Jun 4 2020, 22:39

This revision is now accepted and ready to land.Jun 4 2020, 22:39

Harbormaster completed remote builds in B11217: Diff 20925.Jun 4 2020, 22:48

jasonbcox added a child revision: D6379: [devtools] Use -daemon instead of backgrounding bitcoind.Jun 4 2020, 22:53

Closed by commit rABC3aa12ec3b525: [devtools] Use a trap to cleanup bitcoind instead of a background process (authored by jasonbcox). · Explain WhyJun 4 2020, 23:10

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC3aa12ec3b525: [devtools] Use a trap to cleanup bitcoind instead of a background process.

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

bitcoind-exit-on-log.sh

18 lines

Diff 20929

View Options

contrib/devtools/bitcoind-exit-on-log.sh

[devtools] Use a trap to cleanup bitcoind instead of a background processClosedPublicActions