Page MenuHomePhabricator

[devtools] Use -daemon instead of backgrounding bitcoind
ClosedPublic

Authored by jasonbcox on Jun 4 2020, 22:53.

Details

Summary

Since the behavior change in -printtoconsole, our IBD tests in CI
vomit everything into the Teamcity logs, making them difficult to navigate in
a browser.

This patch daemonizes bitcoind instead of putting it in the background so that
logs only get written to a file. The file is part of the build artifacts,
so it can still be inspected if need be.

One minor downside of doing it this way is that bitcoind's exit code is no
longer accessible to this script. Since the log file is available, that shouldn't
matter too much.

Depends on D6378

Test Plan

Should complete successfully:

./bitcoind-exit-on-log.sh --grep 'New outbound peer connected' --params "-datadir=/home/jasonbcox/.bitcoin"
ps aux | grep bitcoind    # verify no subprocesses are still running

Run the above again, but Ctrl+C it before it finishes. Again, verify no dangling processes.

Run IBD in CI.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable