Page MenuHomePhabricator

[land-bot] Clarify review status error message
ClosedPublic

Authored by jasonbcox on Jun 5 2020, 18:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8227e3687e9b: [land-bot] Clarify review status error message
Summary

This clarifies the error message in less-common cases such as
when a revision has already been landed. Prior to this patch,
it appears as if the revision was never reviewed at all. It's best
that we provide the review status to the user so they can make
a judgement of what the root cause is.

Test Plan
CONDUIT_TOKEN=<token> ./land-patch.sh -r D6379

Outputs:

Error: Revision 'D6379' is not accepted. Review status is: "published"