Page MenuHomePhabricator
Differential D6395

Merge #15330: test: Fix race in p2p_invalid_messages
ClosedPublic
Actions

Authored by jasonbcox on Jun 5 2020, 21:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC76ebb03789ff: Merge #15330: test: Fix race in p2p_invalid_messages
Summary

fac3a054cb test: Fix race in p2p_invalid_messages (MarcoFalke)

Pull request description:

After we change our magic bytes, the node may or may not send us messages such as feefilter or sendheaders, which would be rejected by `_on_data`.

Solve that by replacing `_on_data` with a noop.

Tree-SHA512: bd25a81f0c6e31f09155e00abab8062777d827b9210d6a9b85ef35cfe5069338f100fecf058842f41a1f134fdb3cf7ac1fe80db493e4dab7988acdacb33149df

Backport of Core PR15330

Test Plan

test_runner.py p2p_invalid_messages

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 5 2020, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 21:41
jasonbcox requested review of this revision.Jun 5 2020, 21:41
teamcity edited the summary of this revision. (Show Details)Jun 5 2020, 21:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox added a child revision: D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.Jun 5 2020, 21:44
Harbormaster completed remote builds in B11239: Diff 20964.Jun 5 2020, 22:01
deadalnix accepted this revision.Jun 5 2020, 23:29
This revision is now accepted and ready to land.Jun 5 2020, 23:29
Closed by commit rABC76ebb03789ff: Merge #15330: test: Fix race in p2p_invalid_messages (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJun 8 2020, 16:52
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC76ebb03789ff: Merge #15330: test: Fix race in p2p_invalid_messages.

Revision Contents
Changeset List

PathSize
test/
functional/
5 lines

Diff 21094

View Options

test/functional/p2p_invalid_messages.py

Loading...