Differential D6402

[backport#14821] Replace CAffectedKeysVisitor with descriptor based logic
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 10:14.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC3f4c090205bc: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic

Summary

0e75f44a0 Replace CAffectedKeysVisitor with descriptor based logic (Pieter Wuille)

Pull request description:

It seems we don't need a custom visitor pattern anymore to find what keys are affected by a script. Instead, infer the descriptor, and see which keys it expands to.

Backport of Core PR14821

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 6 2020, 10:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 10:14

majcosta requested review of this revision.Jun 6 2020, 10:14

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11251: Diff 20978.Jun 6 2020, 10:23

deadalnix accepted this revision.Jun 6 2020, 10:41

This revision is now accepted and ready to land.Jun 6 2020, 10:41

majcosta added a child revision: D6403: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types.Jun 6 2020, 10:42

Closed by commit rABC3f4c090205bc: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic (authored by MeshCollider <dobsonsa68@gmail.com>, committed by majcosta). · Explain WhyJun 6 2020, 10:45

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC3f4c090205bc: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

59 lines

Diff 20983

View Options

[backport#14821] Replace CAffectedKeysVisitor with descriptor based logicClosedPublicActions