Differential D6410

Change ImportScriptPubKeys' internal to apply_label
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2020, 16:40.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC33f713967dd5: Change ImportScriptPubKeys' internal to apply_label

Summary

The internal bool was only to indicate whether the given label should
be applied as things that are internal should not have a label. To make
this clearer, we change internal to apply_label and invert its usage
so things that have labels set this to true in order to have their labels
applied.

This is a partial backport of Core PR16301 : https://github.com/bitcoin/bitcoin/pull/16301/commits/ab28e31c9563bd2cd1e4a088ffd2479517dc83f2

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 6 2020, 16:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 16:40

deadalnix requested review of this revision.Jun 6 2020, 16:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11259: Diff 20995.Jun 6 2020, 16:51

deadalnix added a child revision: D6413: Have importpubkey use CWallet's ImportScriptPubKeys and ImportPubKeys functions.Jun 6 2020, 17:56

majcosta accepted this revision.Jun 7 2020, 01:40

This revision is now accepted and ready to land.Jun 7 2020, 01:40

Closed by commit rABC33f713967dd5: Change ImportScriptPubKeys' internal to apply_label (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 7 2020, 11:17

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC33f713967dd5: Change ImportScriptPubKeys' internal to apply_label.

Revision Contents
Changeset List

Path

Size

src/

wallet/

2 lines

4 lines

4 lines

Diff 21037

src/wallet/rpcdump.cpp

Loading...

src/wallet/wallet.h

Loading...

src/wallet/wallet.cpp

Loading...