Page MenuHomePhabricator

Change ImportScriptPubKeys' internal to apply_label
ClosedPublic

Authored by deadalnix on Sat, Jun 6, 16:40.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC33f713967dd5: Change ImportScriptPubKeys' internal to apply_label
Summary

The internal bool was only to indicate whether the given label should
be applied as things that are internal should not have a label. To make
this clearer, we change internal to apply_label and invert its usage
so things that have labels set this to true in order to have their labels
applied.

This is a partial backport of Core PR16301 : https://github.com/bitcoin/bitcoin/pull/16301/commits/ab28e31c9563bd2cd1e4a088ffd2479517dc83f2

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sat, Jun 6, 16:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jun 6, 16:40
deadalnix requested review of this revision.Sat, Jun 6, 16:40
teamcity edited the summary of this revision. (Show Details)Sat, Jun 6, 16:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta accepted this revision.Sun, Jun 7, 01:40
This revision is now accepted and ready to land.Sun, Jun 7, 01:40