Page MenuHomePhabricator

Have importaddress use ImportScripts and ImportScriptPubKeys
ClosedPublic

Authored by deadalnix on Sat, Jun 6, 18:01.

Details

Summary

Also removes the now unused ImportAddress and ImportScript from rpcdump.cpp

Behavior changes:

  • No errors will be thrown when the script or key already exists in the wallet.
  • If the key or script is already in the wallet, their labels will be updated.

This is a partial backport of Core PR16301 : https://github.com/bitcoin/bitcoin/pull/16301/commits/94bf156f391759420465b2ff8c44f5f150246c7f

Depends on D6413

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sat, Jun 6, 18:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jun 6, 18:01
deadalnix requested review of this revision.Sat, Jun 6, 18:01
teamcity edited the summary of this revision. (Show Details)Sat, Jun 6, 18:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta accepted this revision.Sun, Jun 7, 21:02
This revision is now accepted and ready to land.Sun, Jun 7, 21:02