make check && ./qa/pull-tester/rpc-tests.py
Details
Details
- Reviewers
deadalnix freetrader - Group Reviewers
Restricted Project - Commits
- rSTAGING11e116fa1ab2: Convert SelectCoinsMinConf to use Amount class
rABC11e116fa1ab2: Convert SelectCoinsMinConf to use Amount class
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- SelectCoinsMinConf
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1064 Build 1064: arc lint + arc unit
Event Timeline
| src/wallet/wallet.cpp | ||
|---|---|---|
| 2351 | This is not the same thing. | |
| src/wallet/wallet.cpp | ||
|---|---|---|
| 2351 | std::numeric_limits<Amount>::max() is zero for non-numeric values like Amount. While this is not the same, nobody can ever have a wallet with MAX_MONEY in it. To me it is a sensible replacement as a greatest upper bound for the selection below. However, if you want it changed, please let me know what would make sense here to you. | |