Page MenuHomePhabricator
Differential D6424

Add tests and documentation for blocksonly
ClosedPublic
Actions

Authored by deadalnix on Jun 7 2020, 00:14.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCd58b083bf5f0: Add tests and documentation for blocksonly
Summary
  • net: Rename ::fRelayTxes to ::g_relay_txes

This helps to distinguish it from CNode::fRelayTxes and avoid bugs like
425278d17bd0edf8a3a7cc81e55016f7fd8e7726

  • test: Format predicate source as multiline on error
  • test: Add test for p2p_blocksonly
  • doc: Mention blocksonly in reduce-traffic.md, unhide option

This is a backport of Core PR15990

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 7 2020, 00:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 00:14
deadalnix requested review of this revision.Jun 7 2020, 00:14
teamcity edited the summary of this revision. (Show Details)Jun 7 2020, 00:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11275: Diff 21016.Jun 7 2020, 00:27
deadalnix added a child revision: D6429: Add 2 outbound block-relay-only connections.Jun 7 2020, 01:08
deadalnix added a child revision: D6435: Disconnect peers violating blocks-only mode.Jun 7 2020, 13:24
majcosta accepted this revision.Jun 7 2020, 21:23
This revision is now accepted and ready to land.Jun 7 2020, 21:23
Closed by commit rABCd58b083bf5f0: Add tests and documentation for blocksonly (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJun 8 2020, 00:21
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCd58b083bf5f0: Add tests and documentation for blocksonly.

Revision Contents
Changeset List

PathSize
doc/
13 lines
src/
11 lines
2 lines
2 lines
6 lines
rpc/
2 lines
test/
functional/
64 lines
test_framework/
8 lines
2 lines

Diff 21062

View Options

doc/reduce-traffic.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

test/functional/p2p_blocksonly.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...