Differential D6435

Disconnect peers violating blocks-only mode
ClosedPublic
Actions

Authored by deadalnix on Jun 7 2020, 13:24.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCa93f717e006c: Disconnect peers violating blocks-only mode

Summary

If we set fRelay=false in our VERSION message, and a peer sends an INV or TX
message anyway, disconnect. Since we use fRelay=false to minimize bandwidth,
we should not tolerate remaining connected to a peer violating the protocol.

This is a partial backport of Core PR15759 : https://github.com/bitcoin/bitcoin/pull/15759/commits/0ba08020c9791f7caf5986ad6490c16a2b66cd83

Depends on D6424

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 7 2020, 13:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 13:24

deadalnix requested review of this revision.Jun 7 2020, 13:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11290: Diff 21040.Jun 7 2020, 13:34

majcosta accepted this revision.Jun 7 2020, 22:25

This revision is now accepted and ready to land.Jun 7 2020, 22:25

Closed by commit rABCa93f717e006c: Disconnect peers violating blocks-only mode (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by deadalnix). · Explain WhyJun 8 2020, 03:24

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCa93f717e006c: Disconnect peers violating blocks-only mode.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

11 lines

test/

functional/

p2p_blocksonly.py

11 lines

Diff 21068

View Options

src/net_processing.cpp