Page MenuHomePhabricator
Differential D6425

[backport#16244] Move wallet creation out of the createwallet rpc into its own function
ClosedPublic
Actions

Authored by majcosta on Jun 7 2020, 00:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC49478a329299: [backport#16244] Move wallet creation out of the createwallet rpc into its own…
Summary

https://github.com/bitcoin/bitcoin/pull/16244/commits/1aecdf2063cbe28d4715ae5ae1a7e51b860c9f4d

Depends on D6423

Backport of Core PR16244

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 7 2020, 00:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 00:14
majcosta requested review of this revision.Jun 7 2020, 00:14
teamcity edited the summary of this revision. (Show Details)Jun 7 2020, 00:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11276: Diff 21015.Jun 7 2020, 00:27
deadalnix accepted this revision.Jun 7 2020, 01:14
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
3175 ↗(On Diff #21015)

Clearly someone really disliked switch statements...

This revision is now accepted and ready to land.Jun 7 2020, 01:14
majcosta updated this revision to Diff 21028.Jun 7 2020, 01:25

rebase

Harbormaster completed remote builds in B11283: Diff 21028.Jun 7 2020, 01:48
Closed by commit rABC49478a329299: [backport#16244] Move wallet creation out of the createwallet rpc into its own… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJun 7 2020, 01:51
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC49478a329299: [backport#16244] Move wallet creation out of the createwallet rpc into its own….
majcosta mentioned this in D7035: [backport#16399 1/3] Place out args at the end for CreateWallet.Jul 25 2020, 03:10
majcosta mentioned this in rABC49fbaaec0345: [backport#16399 1/3] Place out args at the end for CreateWallet.Jul 25 2020, 19:41

Revision Contents
Changeset List

PathSize
src/
wallet/
72 lines
8 lines
72 lines

Diff 21031

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...