Page MenuHomePhabricator
Differential D7035

[backport#16399 1/3] Place out args at the end for CreateWallet
ClosedPublic
Actions

Authored by majcosta on Jul 25 2020, 03:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC49fbaaec0345: [backport#16399 1/3] Place out args at the end for CreateWallet
Summary

https://github.com/bitcoin/bitcoin/pull/16399/commits/3199610ad3b93b849f2cb55a8ed3a39a32bbdffc

note: this one has already been added in D6425

Partial backport of Core PR16399

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 25 2020, 03:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2020, 03:10
majcosta requested review of this revision.Jul 25 2020, 03:10
majcosta added a child revision: D7036: [backport#16399 2/3] Return error for ignored passphrase through disable private keys option.
Harbormaster completed remote builds in B12155: Diff 22505.Jul 25 2020, 03:28
deadalnix accepted this revision.Jul 25 2020, 12:59
This revision is now accepted and ready to land.Jul 25 2020, 12:59
Closed by commit rABC49fbaaec0345: [backport#16399 1/3] Place out args at the end for CreateWallet (authored by Fabian Jahr <fabian.jahr@whu.edu>, committed by majcosta). · Explain WhyJul 25 2020, 19:41
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC49fbaaec0345: [backport#16399 1/3] Place out args at the end for CreateWallet.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
6 lines
4 lines
4 lines

Diff 22515

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...