Differential D6438

test: Replace recursive lock with locking annotations
ClosedPublic
Actions

Authored by deadalnix on Jun 7 2020, 16:46.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC7f47e3411d6a: test: Replace recursive lock with locking annotations

Summary

Also, use m_node.mempool instead of the global

This is a partial backport of Core PR17407 : https://github.com/bitcoin/bitcoin/pull/17407/commits/8888ad02e204b0fa7a2ea2cfed2fc3f298cf1623

Depends on D6437

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 7 2020, 16:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 16:46

deadalnix requested review of this revision.Jun 7 2020, 16:46

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D6439: scripted-diff: Replace ::mempool with m_node.mempool in tests.Jun 7 2020, 16:48

Harbormaster completed remote builds in B11293: Diff 21043.Jun 7 2020, 16:58

majcosta accepted this revision.Jun 7 2020, 22:43

This revision is now accepted and ready to land.Jun 7 2020, 22:43

Closed by commit rABC7f47e3411d6a: test: Replace recursive lock with locking annotations (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJun 8 2020, 03:00

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7f47e3411d6a: test: Replace recursive lock with locking annotations.

Revision Contents
Changeset List

Path

Size

src/

test/

miner_tests.cpp

32 lines

txvalidationcache_tests.cpp

20 lines

Diff 21066

View Options

src/test/miner_tests.cpp