Page MenuHomePhabricator
Differential D6454

Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check
ClosedPublic
Actions

Authored by nakihito on Jun 8 2020, 17:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC7de90a0236ab: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check
Summary

2f1a30c63 Fix MAX_STANDARD_TX_WEIGHT check (Johnson Lau)

Pull request description:

As suggested by the constant name and its comment in policy.h, a transaction with a weight of exactly MAX_STANDARD_TX_WEIGHT should be allowed. Users could be confused.

Tree-SHA512: af417de1c6a2e6796ebbb39aa0caad8764302ded155cb1bbfbe457e4567c199cc53256189832b17d4aeec369e190b3edd4c6116d5f0b8cf0ede6dfb4ed83bdd3

Backport of Core PR13096

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 8 2020, 17:32
Owners added a reviewer: Restricted Owners Package.Jun 8 2020, 17:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 17:32
nakihito requested review of this revision.Jun 8 2020, 17:32
teamcity edited the summary of this revision. (Show Details)Jun 8 2020, 17:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11321: Diff 21098.Jun 8 2020, 17:50
Fabien accepted this revision.Jun 9 2020, 06:27
This revision is now accepted and ready to land.Jun 9 2020, 06:27
Closed by commit rABC7de90a0236ab: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 9 2020, 17:45
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC7de90a0236ab: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check.

Revision Contents
Changeset List

PathSize
src/
4 lines
policy/
2 lines
wallet/
2 lines

Diff 21157

View Options

src/net_processing.cpp

Loading...
View Options

src/policy/policy.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...