Page MenuHomePhabricator
Differential D6470

Implement poll() on systems which support it properly.
ClosedPublic
Actions

Authored by nakihito on Jun 8 2020, 21:48.

Details

Reviewers
majcosta
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC898802efaa58: Implement poll() on systems which support it properly.
Summary

This eliminates the restriction on maximum socket descriptor number.

Partial backport of Core PR14336
https://github.com/bitcoin/bitcoin/pull/14336/commits/11cc491a288a73e911be24a285e12abd57df7d04

Depends on D6461

Test Plan
ninja
ninja check-all
src/bitoind

Verify normal node behavior.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 8 2020, 21:48
Owners added a reviewer: Restricted Owners Package.Jun 8 2020, 21:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 21:48
nakihito requested review of this revision.Jun 8 2020, 21:48
nakihito planned changes to this revision.
teamcity edited the summary of this revision. (Show Details)Jun 8 2020, 21:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11339: Diff 21123.Jun 8 2020, 22:02
nakihito requested review of this revision.Jun 8 2020, 22:15
nakihito edited the summary of this revision. (Show Details)
nakihito added a parent revision: D6461: Move SocketEvents logic to private method..
nakihito added a child revision: D6471: Increase maxconnections limit when using poll..
majcosta accepted this revision.Jun 8 2020, 23:53
This revision is now accepted and ready to land.Jun 8 2020, 23:53
Closed by commit rABC898802efaa58: Implement poll() on systems which support it properly. (authored by Patrick Strateman <patrick.strateman@gmail.com>, committed by nakihito). · Explain WhyJun 9 2020, 23:42
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC898802efaa58: Implement poll() on systems which support it properly..

Revision Contents
Changeset List

PathSize
src/
12 lines
64 lines
22 lines

Diff 21204

View Options

src/compat.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/netbase.cpp

Loading...