Move SocketEvents logic to private method.
ClosedPublic
Actions

Authored by nakihito on Jun 8 2020, 20:12.

Details

Reviewers

majcosta
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC96827c217616: Move SocketEvents logic to private method.

Summary

This separates the select() logic from the socket handling logic, setting up
for a switch to poll().

Partial backport of Core PR14336
https://github.com/bitcoin/bitcoin/pull/14336/commits/28211a4bc9c65859b641b81a0541726a0e01988f

Depends on D6460

Test Plan

ninja
ninja check-all
src/bitcoind -debug=net

Verify normal node behavior.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 8 2020, 20:12

Owners added a reviewer: Restricted Owners Package.Jun 8 2020, 20:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 20:12

nakihito requested review of this revision.Jun 8 2020, 20:12

nakihito planned changes to this revision.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11330: Diff 21111.Jun 8 2020, 20:23

nakihito requested review of this revision.Jun 8 2020, 22:15

nakihito edited the summary of this revision. (Show Details)

nakihito added a parent revision: D6460: Move GenerateSelectSet logic to private method..

nakihito added a child revision: D6470: Implement poll() on systems which support it properly..

majcosta accepted this revision.Jun 8 2020, 23:55

This revision is now accepted and ready to land.Jun 8 2020, 23:55

jasonbcox accepted this revision.Jun 9 2020, 23:05

Closed by commit rABC96827c217616: Move SocketEvents logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>, committed by nakihito). · Explain WhyJun 9 2020, 23:32

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC96827c217616: Move SocketEvents logic to private method..

Revision Contents
Changeset List

Path

Size

src/

net.h

2 lines

net.cpp

39 lines

Diff 21203

View Options

src/net.h