Page MenuHomePhabricator
Differential D6473

[backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM
ClosedPublic
Actions

Authored by majcosta on Jun 8 2020, 23:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb160ed70b766: [backport#14060] ZMQ: add options to configure outbound message high water mark…
Summary

a4edb168b635b6f5c36324e44961cd42cf9bbbaa ZMQ: add options to configure outbound message high water mark, aka SNDHWM (mruddy)

Pull request description:

ZMQ: add options to configure outbound message high water mark, aka SNDHWM

This is my attempt at https://github.com/bitcoin/bitcoin/pull/13315

Backport of Core PR14060 https://github.com/bitcoin/bitcoin/pull/14060/commits/a4edb168b635b6f5c36324e44961cd42cf9bbbaa

Test Plan
ninja check
test_runner.py interface_zmq

Diff Detail

Event Timeline

majcosta created this revision.Jun 8 2020, 23:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 23:15
majcosta requested review of this revision.Jun 8 2020, 23:15
teamcity edited the summary of this revision. (Show Details)Jun 8 2020, 23:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11343: Diff 21128.Jun 8 2020, 23:34
Fabien requested changes to this revision.Jun 9 2020, 07:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/zmq/zmqrpc.cpp
34

No, you removed RPCHelpMan

This revision now requires changes to proceed.Jun 9 2020, 07:52
majcosta updated this revision to Diff 21140.Jun 9 2020, 14:46

undid RPCHelpMan removal

Harbormaster completed remote builds in B11351: Diff 21140.Jun 9 2020, 15:04
Fabien accepted this revision.Jun 9 2020, 17:45
This revision is now accepted and ready to land.Jun 9 2020, 17:45
Closed by commit rABCb160ed70b766: [backport#14060] ZMQ: add options to configure outbound message high water mark… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyJun 9 2020, 17:59
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCb160ed70b766: [backport#14060] ZMQ: add options to configure outbound message high water mark….
PiRK mentioned this in D10305: Use Flags enum in AddArg() (follow-up).Oct 12 2021, 08:30
PiRK mentioned this in rABC67e5b25078d5: Use Flags enum in AddArg() (follow-up).Oct 14 2021, 06:21

Revision Contents
Changeset List

PathSize
contrib/
zmq/
1 line
doc/
13 lines
src/
25 lines
zmq/
15 lines
2 lines
9 lines
2 lines
17 lines
35 lines
test/
functional/
8 lines
lint/
5 lines

Diff 21128

View Options

contrib/zmq/zmq_sub.py

Loading...
View Options

doc/zmq.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/zmq/zmqabstractnotifier.h

Loading...
View Options

src/zmq/zmqabstractnotifier.cpp

Loading...
View Options

src/zmq/zmqnotificationinterface.cpp

Loading...
View Options

src/zmq/zmqpublishnotifier.h

Loading...
View Options

src/zmq/zmqpublishnotifier.cpp

Loading...
View Options

src/zmq/zmqrpc.cpp

Loading...
View Options

test/functional/interface_zmq.py

Loading...
View Options

test/lint/check-doc.py

Loading...