Merge #15194: Add comment describing fDisconnect behavior
ClosedPublic
Actions

Authored by nakihito on Jun 8 2020, 23:53.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC47f476c061cf: Merge #15194: Add comment describing fDisconnect behavior

Summary

5b4283cb81b5d3023b9868d121b22b1f387a50ca Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

Motivated by @Sjors here: https://github.com/bitcoin/bitcoin/pull/14605#discussion_r248384309

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751

Backport of core PR15194.

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR15194

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11344
Build 21579: Default Diff Build & Tests
Build 21578: Build without Wallet
Build 21577: Build with clang-10
Build 21576: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 8 2020, 23:53

Owners added a reviewer: Restricted Owners Package.Jun 8 2020, 23:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 23:53

nakihito requested review of this revision.Jun 8 2020, 23:53

Harbormaster completed remote builds in B11344: Diff 21129.Jun 9 2020, 00:04

Fabien accepted this revision.Jun 9 2020, 06:44

Fabien edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Jun 9 2020, 06:44

Closed by commit rABC47f476c061cf: Merge #15194: Add comment describing fDisconnect behavior (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 9 2020, 18:24

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC47f476c061cf: Merge #15194: Add comment describing fDisconnect behavior.

Revision Contents
Changeset List

Path

Size

src/

net.h

2 lines

Diff 21129

View Options

Merge #15194: Add comment describing fDisconnect behaviorClosedPublicActions